[PATCH] D76885: [lld][COFF][ELF][WebAssembly] Replace --[no-]threads /threads[:no] with --threads={all,1,2,...} /threads:{all,1,2,...}

[Alexandre Ganea via Phabricator via llvm-commits]

aganea accepted this revision.
aganea added a comment.
This revision is now accepted and ready to land.

LGTM, thanks! Maybe wait a bit in case there are other comments.

Some todos for the record:

- This line: https://github.com/llvm/llvm-project/blob/master/lld/lib/ReaderWriter/MachO/LayoutPass.cpp#L464 - should use the `parallelSort()` API, but could be done later.
- `parallel::strategy.ThreadsRequested == 1` is a bit verbose and error prone, it could be an API like `parallel::strategy.useThreads()` - this could be done in a subsequent commit.
- Is there value for the code in `lld/Common/Threads.h`? It could be replaced with direct calls to `Parallel.h` APIs instead? (assuming they handle the "no multi-threading" case)
- Same function for handling `--threads=` in all three drivers and `get_threadpool_strategy()`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76885/new/

https://reviews.llvm.org/D76885