[PATCH] D76539: [CodeGenPrepare] Delete intrinsic call to llvm.assume to enable more tailcall

Guozhi Wei via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 14:11:41 PDT 2020


Carrot added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:1971
+    case Intrinsic::assume: {
+      II->eraseFromParent();
+      return true;
----------------
xbolva00 wrote:
> Do we need to run RecursivelyDeleteTriviallyDeadInstructions on arg?
This function is called in a "while (MadeChange)" loop in function runOnFunction, so the instruction generates the assume condition will be deleted in next iteration. Either or not call RecursivelyDeleteTriviallyDeadInstructions are both OK.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76539/new/

https://reviews.llvm.org/D76539





More information about the llvm-commits mailing list