[llvm] 9e81249 - [Matrix] Rename emitChainedMatrixMultiply to emitMatrixMultiply (NFC).

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 30 03:18:06 PDT 2020


Author: Florian Hahn
Date: 2020-03-30T11:17:25+01:00
New Revision: 9e81249d7614df252e2047b5c6c20f45159b563d

URL: https://github.com/llvm/llvm-project/commit/9e81249d7614df252e2047b5c6c20f45159b563d
DIFF: https://github.com/llvm/llvm-project/commit/9e81249d7614df252e2047b5c6c20f45159b563d.diff

LOG: [Matrix] Rename emitChainedMatrixMultiply to emitMatrixMultiply (NFC).

The Chained in the name potentially leads to confusion. Also updated the
comment to drop the unnecessary mention of tile-sized.

Added: 
    

Modified: 
    llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
index 671da3f53993..6b66310b1e3d 100644
--- a/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
+++ b/llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp
@@ -873,11 +873,11 @@ class LowerMatrixIntrinsics {
     }
   }
 
-  /// Compute Res += A * B for tile-sized matrices with left-associating
+  /// Compute \p Result += \p A * \p B for input matrices with left-associating
   /// addition.
-  void emitChainedMatrixMultiply(MatrixTy &Result, const MatrixTy &A,
-                                 const MatrixTy &B, bool AllowContraction,
-                                 IRBuilder<> &Builder, bool isTiled) {
+  void emitMatrixMultiply(MatrixTy &Result, const MatrixTy &A,
+                          const MatrixTy &B, bool AllowContraction,
+                          IRBuilder<> &Builder, bool isTiled) {
     const unsigned VF = std::max<unsigned>(
         TTI.getRegisterBitWidth(true) /
             Result.getElementType()->getPrimitiveSizeInBits().getFixedSize(),
@@ -936,7 +936,7 @@ class LowerMatrixIntrinsics {
 
     bool AllowContract = AllowContractEnabled || (isa<FPMathOperator>(MatMul) &&
                                                   MatMul->hasAllowContract());
-    emitChainedMatrixMultiply(Result, Lhs, Rhs, AllowContract, Builder, false);
+    emitMatrixMultiply(Result, Lhs, Rhs, AllowContract, Builder, false);
     finalizeLowering(MatMul, Result, Builder);
   }
 


        


More information about the llvm-commits mailing list