[PATCH] D76822: [VE] Update lea/load/store instructions

Mon Mar 30 00:30:04 PDT 2020

simoll added a comment.

In D76822#1948979 <https://reviews.llvm.org/D76822#1948979>, @kaz7 wrote:

> I did `git ci -a --amend` and `arc diff`.  I guess it corrupts comments from reviewers.  I'll try `git ci -a` and `arc diff` next time.

It's ok to squash all changes into one commit by amending to it. Btw, i recommend using `arc diff --preview` to double check that the commit is clean before submitting it to Phabricator.

================
Comment at: llvm/lib/Target/VE/VEISelDAGToDAG.cpp:159
+
   if (Addr.getOpcode() == ISD::ADD) {
     if (Addr.getOperand(0).getOpcode() == VEISD::Lo ||
----------------
kaz7 wrote:
> simoll wrote:
> > This is a generalized version of `SelectionDAG::isBaseWithConstantOffset`. I suppose this code (up until line 177) should be moved into SelectionDAG, eg as `SelectionDAG::isBaseWithOffset`.
> > You can do that in a followup patch.
> Regarding to isBaseWithOffset, I'll try that.  Should I submit them as independent patch or just append modifications on SelectionDAG in this patch?
Better make it a separate patch for Phabricator after this patch is committed.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76822/new/

https://reviews.llvm.org/D76822