[PATCH] D76903: Add a flag on the context to protect against creation of operations in unregistered dialects

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula requested changes to this revision.
bondhugula added a comment.
This revision now requires changes to proceed.

The commit summary opening "By default, the verifier won't allow operations with unregistered dialect. " reads as if this was the situation before. Consider rephrasing please. "Change the verifier to disallow ..."? Besides "operations with unregistered dialect", what about unregistered operations, i.e., operations that aren't part of any registered dialect? It looks like you are equating the two, and did you mean to use the latter for this patch?



================
Comment at: mlir/tools/mlir-opt/mlir-opt.cpp:89
+    "allow-unregistered-dialect",
+    cl::desc("Allow operation for unregistered dialects"), cl::init(false));
+
----------------
Nit: "operation for unregistered dialects" isn't really meaningful. Rephrase here and other places.


================
Comment at: mlir/tools/mlir-opt/mlir-opt.cpp:169
+                            splitInputFile, verifyDiagnostics, verifyPasses,
+                            allowUnregisteredDialects));
 }
----------------
`clAllowUnregisteredDialects` ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76903/new/

https://reviews.llvm.org/D76903