[PATCH] D77015: Fix mismatch in prologue and epilogue for funclets on AArch64 Windows

Daniel Frampton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 29 12:50:31 PDT 2020


danielframpton marked 2 inline comments as done.
danielframpton added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64FrameLowering.cpp:1038
+    if (isAsynchronousEHPersonality(Per)) {
+      BuildMI(MBB, MBBI, DL, TII->get(TargetOpcode::COPY), AArch64::FP)
+          .addReg(AArch64::X1)
----------------
efriedma wrote:
> I think this COPY still needs to happen after the SEH_PrologEnd, or else we need to emit an SEH opcode for it.  Otherwise, the SEH opcodes won't match the instructions.  (The mismatch probably doesn't have many visible side-effects here, but still.)
Done


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77015/new/

https://reviews.llvm.org/D77015





More information about the llvm-commits mailing list