[PATCH] D76539: [CodeGenPrepare] Delete intrinsic call to llvm.assume to enable more tailcall

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 29 10:08:22 PDT 2020


xbolva00 added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:1971
+    case Intrinsic::assume: {
+      II->eraseFromParent();
+      return true;
----------------
Do we need to run RecursivelyDeleteTriviallyDeadInstructions on arg?


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:1992
     case Intrinsic::is_constant:
-      llvm_unreachable("llvm.is.constant.* should have been lowered already");
+      report_fatal_error("llvm.is.constant.* should have been lowered already");
     case Intrinsic::aarch64_stlxr:
----------------
Split these changes to new patch?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76539/new/

https://reviews.llvm.org/D76539





More information about the llvm-commits mailing list