[PATCH] D76151: [MC][X86] Allow SHT_PROGBITS for .eh_frame on x86-64

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Mar 28 17:12:10 PDT 2020


MaskRay added a comment.

In D76151#1948225 <https://reviews.llvm.org/D76151#1948225>, @joerg wrote:

> Can you add a variation with .pushsection for `@progbits` and `@nobits`? Otherwise LGTM.


I think a .pushsection test will be redundant as it shares code with .section.

I am waiting for the resolution https://groups.google.com/forum/#!topic/x86-64-abi/7sr4E6THl3g , otherwise I cannot say "x86-64 psABI allows SHT_PROGBITS as an alternative section type" :/


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76151/new/

https://reviews.llvm.org/D76151





More information about the llvm-commits mailing list