[PATCH] D76428: [cmake] Disable C4129 warning for MSVC.

Sat Mar 28 11:49:23 PDT 2020

fhahn added a comment.

Thanks for all the input!

In D76428#1932354 <https://reviews.llvm.org/D76428#1932354>, @amccarth wrote:

> In D76428#1932174 <https://reviews.llvm.org/D76428#1932174>, @rnk wrote:
>
> > I messed around with this in godbolt and couldn't reproduce the warning with any version that I tried:
> >  https://gcc.godbolt.org/z/7-c8oa
> >  Not sure if my example works, though.
>
>
> The key is that the raw string has to be an argument to a macro that then tries to stringify the argument.

I could move the string to a variable outside of the macro, if that would fix the warning. Unfortunately I cannot confirm it fixes the warning on my setup.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76428/new/

https://reviews.llvm.org/D76428