[PATCH] D76981: [lld][ELF] Mark empty NOLOAD output sections SHT_NOBITS instead of SHT_PROGBITS

[Fangrui Song via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGfdc41aa22c60: [lld][ELF] Mark empty NOLOAD output sections SHT_NOBITS instead of SHT_PROGBITS (authored by schultetwin1, committed by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76981/new/

https://reviews.llvm.org/D76981

Files:
  lld/ELF/ScriptParser.cpp
  lld/test/ELF/linkerscript/noload.s


Index: lld/test/ELF/linkerscript/noload.s
===================================================================
--- lld/test/ELF/linkerscript/noload.s
+++ lld/test/ELF/linkerscript/noload.s
@@ -3,13 +3,15 @@
 # RUN: echo "SECTIONS { \
 # RUN:        .data_noload_a (NOLOAD) : { *(.data_noload_a) } \
 # RUN:        .data_noload_b (0x10000) (NOLOAD) : { *(.data_noload_b) } \
+# RUN:        .no_input_sec_noload (NOLOAD) : { . += 1; } \
 # RUN:        .text (0x20000) : { *(.text) } };" > %t.script
 # RUN: ld.lld -o %t --script %t.script %t.o
 # RUN: llvm-readelf -S -l %t | FileCheck %s
 
-# CHECK:      Name           Type   Address          Off               Size
-# CHECK:      .data_noload_a NOBITS 0000000000000000 [[OFF:[0-9a-f]+]] 001000
-# CHECK-NEXT: .data_noload_b NOBITS 0000000000010000 [[OFF]]           001000
+# CHECK:      Name                 Type   Address          Off               Size
+# CHECK:      .data_noload_a       NOBITS 0000000000000000 [[OFF:[0-9a-f]+]] 001000
+# CHECK-NEXT: .data_noload_b       NOBITS 0000000000010000 [[OFF]]           001000
+# CHECK-NEXT: .no_input_sec_noload NOBITS 0000000000011000 [[OFF]]           000001
 
 # CHECK:      Type Offset   VirtAddr           PhysAddr
 # CHECK-NEXT: LOAD 0x001000 0x0000000000020000 0x0000000000020000
Index: lld/ELF/ScriptParser.cpp
===================================================================
--- lld/ELF/ScriptParser.cpp
+++ lld/ELF/ScriptParser.cpp
@@ -746,6 +746,7 @@
   expect("(");
   if (consume("NOLOAD")) {
     cmd->noload = true;
+    cmd->type = SHT_NOBITS;
   } else {
     skip(); // This is "COPY", "INFO" or "OVERLAY".
     cmd->nonAlloc = true;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76981.253359.patch
Type: text/x-patch
Size: 1655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200328/396225d7/attachment-0001.bin>