[PATCH] D76759: [AssumeBundles] Preserve Information from Load/Store

[Tyker via Phabricator via llvm-commits]

Tyker added inline comments.


================
Comment at: llvm/lib/IR/KnowledgeRetention.cpp:189
+    AssumedKnowledgeSet.insert(AK);
+  };
+
----------------
jdoerfert wrote:
> Nit:
> We can have non pointer attributes (later).
> -`Ptr`
> +`V` or `Val`
> (Then we'll also need to rename `setPointer`)
setPointer is just the function from PointerIntPair, Pointer isn't associated with the llvm type of the Value* but the actual C++ type.


================
Comment at: llvm/lib/IR/KnowledgeRetention.cpp:200
+                                  MemInst->getPointerOperand()
+                                      ->getType()
+                                      ->getPointerAddressSpace()))
----------------
jdoerfert wrote:
> The above two lines is `T`, isn't it?
they aren't the same, MemInst->getPointerOperand()->getType() is usually a pointer on the type of T.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76759/new/

https://reviews.llvm.org/D76759