[PATCH] D73086: [DWARF5] Added support for debug_macro section parsing and dumping in llvm-dwarfdump.

[Igor Kudrin via Phabricator via llvm-commits]

ikudrin added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFContext.h:276
-  /// Get a pointer to the parsed DebugMacro object.
-  const DWARFDebugMacro *getDebugMacinfo();
-
----------------
SouraVX wrote:
> SouraVX wrote:
> > ikudrin wrote:
> > > Maybe I am missing something, but I cannot find the discussion where the removal of these public methods was approved.
> > > 
> > > `getDebugMacinfo()` and `getDebugMacinfoDWO()` should not be removed from the public interface. `getDebugMacro()` should be added. `parseMacroOrMacinfo()` should be private and be called from these methods.
> > It was part of effort of removing the redundant code that @jhenderson and you were discussing about https://reviews.llvm.org/D73086#1927338
> @ikudrin While naming `parseMacroMacinfo` or `getMacroMacinfo` can still be debatable, but semantically this `parseMacroMacinfo` function is doing essentially the same thing which these 2 + 1(getDebugMacro) were doing i.e parsing the contents and returning to the caller for dumping the contents.
Not exactly. Look from the perspective of a user of the `DWARFContext` class. Before the patch, they could just call `Context->getDebugMacinfo()`, but now they need to pass way more arguments, some of which are not that obvious (namely, `DumpOpts`) and others are references to a private member of `DWARFContext` (namely, `MacroPtr`). This is a significant degradation of the public interface of `DWARFContext`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73086/new/

https://reviews.llvm.org/D73086