[PATCH] D72194: [MC][ELF] Ensure that mergeable globals with an explicit section are assigned to SHF_MERGE sections with compatible entsizes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 16:32:49 PDT 2020


MaskRay added inline comments.


================
Comment at: llvm/lib/CodeGen/TargetLoweringObjectFileImpl.cpp:706
+      // version 2.35 (https://sourceware.org/bugzilla/show_bug.cgi?id=25380)
+      // versions. Until support is widespread, if we are building without the
+      // integrated assembler, we don't create mergeable sections for these
----------------
Delete stray `versions`.

Delete the last sentence `Until support is widespread...`

In MC, there are several other places such workarounds exist, no need for stating this verbosely.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72194/new/

https://reviews.llvm.org/D72194





More information about the llvm-commits mailing list