[PATCH] D76670: [VirtualFileSystem] Support directory entries in the YAMLVFSWriter

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere planned changes to this revision.
JDevlieghere added a comment.

In D76670#1946630 <https://reviews.llvm.org/D76670#1946630>, @arphaman wrote:

> It looks like you're now adding a dependency on a real filesystem to the VFS writer due to calls to `fs::is_directory`. I think it should be possible to use a VFS write to construct a VFS file without an underlying filesystem, or with an underlying filesystem that doesn't represent the state of your constructed VFS. Is there another way to achieve this goal without depending on the underlying filesystem?


Good point. We could move the check out of the writer and make it the responsibility of the caller, so instead of having just `addFile` we'd also have an `addDirectory`. I'll update the patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76670/new/

https://reviews.llvm.org/D76670