[PATCH] D75684: [mlir][LLVM] Remove pessimizing std::move.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 14:17:13 PDT 2020


dblaikie added a comment.

In D75684#1946846 <https://reviews.llvm.org/D75684#1946846>, @mehdi_amini wrote:

> In D75684#1944248 <https://reviews.llvm.org/D75684#1944248>, @dblaikie wrote:
>
> > >   I received an email on the approval, can you clarify?
> >
> > Ah, guess it might send it specifically to the author only, then?
>
>
> I am only subscriber on this revision, just like the mailing list actually I think.
>
> > But it doesn't seem to make it to the mailing list: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200302/thread.html#751858
>
> Our comments (mine and yours) above haven't ended up on the list either apparently,


They're on the list, but the way the list archive works is on a per-week basis, so our recent posts to this review are here: http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20200323/759235.html

> something else must be going on...

I'm pretty sure it's as I've described it - this isn't the only thread with the problem (check my recent posts to the mailing list as I've flagged a bunch of reviews/reviewers about this & check how they appear in your mail client, examples include: D76935 <https://reviews.llvm.org/D76935>, D74934 <https://reviews.llvm.org/D74934>, D75558 <https://reviews.llvm.org/D75558>, D76189 <https://reviews.llvm.org/D76189> to name a few)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75684/new/

https://reviews.llvm.org/D75684





More information about the llvm-commits mailing list