[PATCH] D73832: Ignore/Drop droppable uses for code-sinking in InstCombine

Fri Mar 27 07:37:08 PDT 2020

Tyker added a comment.

In D73832#1942924 <https://reviews.llvm.org/D73832#1942924>, @MaskRay wrote:

> Pushed a probable fix: 4c52d51e784ca7603969f2a664e5430d41b9d5dc <https://reviews.llvm.org/rG4c52d51e784ca7603969f2a664e5430d41b9d5dc>.

thank you

In D73832#1943096 <https://reviews.llvm.org/D73832#1943096>, @nikic wrote:

> For the record, this change has caused a small but measurable compile-time regression (http://llvm-compile-time-tracker.com/compare.php?from=b539f18c565656cdd49fc0c37efbaa8e584b2d65&to=f1a9efabcb9bc37b663b0e03ed3d5a5aa7cc055e&stat=instructions). It's not a problem for this change taken by itself, but may be a problem if these APIs are going to see significantly wider use.

i added a patch to minimize the overhead by storing inside the Use whether it is droppable. D76923 <https://reviews.llvm.org/D76923>.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73832/new/

https://reviews.llvm.org/D73832