[PATCH] D76889: [MLIR][Vector] Add support for TupleGetOp folding through InsertSlicesOp and ExtractSlicesOp.

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 27 07:03:12 PDT 2020


nicolasvasilache added a comment.

Nice foldings.

One request on my end, could we please beef up the test?
Atm the cases tested are: `tupleIndex = -1, offsets = [4, 0]`, `tupleIndex = -1, offsets = [0, 0]` and `tupleIndex >= 0, offsets = [0, 0]`.

Can you reshuffle things a bit so we get more: `tupleIndex = x, offsets = [y, z]` combinations tested?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76889/new/

https://reviews.llvm.org/D76889





More information about the llvm-commits mailing list