[PATCH] D76278: [AMDGPU] Don't mark the .note section as ALLOC

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 21:44:48 PDT 2020


t-tye added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.cpp:441-443
+  unsigned NoteFlags = 0;
+  if (Os == Triple::AMDHSA)
+    NoteFlags = ELF::SHF_ALLOC;
----------------
Why does the AMDHSA ABI need this note section to be allocated?

@kzhuravl do you have any information about this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76278/new/

https://reviews.llvm.org/D76278





More information about the llvm-commits mailing list