[PATCH] D71793: [WebAssembly] Support wasm exports with zero-length names.

[Dan Gohman via Phabricator via llvm-commits]

sunfish marked 2 inline comments as done.
sunfish added inline comments.


================
Comment at: lld/wasm/InputChunks.h:134
+  llvm::Optional<StringRef> getExportName() const {
+    return function ? function->ExportName : llvm::Optional<StringRef>();
   }
----------------
sbc100 wrote:
> Is there a shorter way to write that?  Does just {} work?
Just {} didn't work, so I don't know of a shorter way offhand.


================
Comment at: llvm/include/llvm/BinaryFormat/Wasm.h:182
   StringRef ImportModule; // For undefined symbols the module of the import
   StringRef ImportName;   // For undefined symbols the name of the import
+  Optional<StringRef> ExportName;   // For symbols to be exported from the final module
----------------
sbc100 wrote:
> Would it make sense to do the same for there two too?  Or is that a followup?
Let's do that in a followup.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71793/new/

https://reviews.llvm.org/D71793