[PATCH] D76890: [GlobalISel] Fix equality for copies from physregs in matchEqualDefs

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 15:47:26 PDT 2020


arsenm added a comment.

No test with the implicit def case you mentioned?



================
Comment at: llvm/lib/CodeGen/GlobalISel/CombinerHelper.cpp:1528
+  //
+  // FIXME: We can probably do better here by checking register liveness.
+  if (any_of(I1->uses(), [](const MachineOperand &MO) {
----------------
ISel should probably not ever think about liveness like this


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76890/new/

https://reviews.llvm.org/D76890





More information about the llvm-commits mailing list