[PATCH] D76868: [AMDGPU] Propagate amdgpu-waves-per-eu to callees

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 11:23:02 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:68
+
+  class FnAttrbutes {
+  private:
----------------
Typo Attrbutes. Also since this isn't strictly for attributes, FunctionProperties?


================
Comment at: llvm/test/CodeGen/AMDGPU/propagate-attributes-clone.ll:141
 attributes #2 = { nounwind "target-features"="+wavefrontsize64" }
 attributes #3 = { nounwind "target-features"="+wavefrontsize64" }
----------------
Test where the caller and callee already have the same attribute?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76868/new/

https://reviews.llvm.org/D76868





More information about the llvm-commits mailing list