[PATCH] D76836: [AMDGPU] Add G16 support to image instructions

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 14:42:15 PDT 2020


arsenm added a comment.

In D76836#1944335 <https://reviews.llvm.org/D76836#1944335>, @Flakebi wrote:

> Thank you for the fast review!
>
> I added G16 to GlobalISel legalization. Is there a part where the image instructions get selected for GlobalISel? I didn’t find it and I guess it doesn’t pick up G16 instructions automatically.
>
> gfx9 does not have G16 (addresses are 32 bit, derivatives 16 bit) only A16 (addresses and derivatives are 16 bit), so it’s tested in `unsupported-image-g16.ll`.


The GLobalISEl selection is stuck in review in D74316 <https://reviews.llvm.org/D74316>


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76836/new/

https://reviews.llvm.org/D76836





More information about the llvm-commits mailing list