[PATCH] D76748: [llvm][Support] Add isZero method for TypeSize. [NFC]

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 13:36:12 PDT 2020


sdesmalen added inline comments.


================
Comment at: llvm/include/llvm/Support/TypeSize.h:153
+  // Returns true if the type size is zero.
+  bool isZero() const { return MinSize == 0; }
+
----------------
nit: I mentioned this to Graham when he first proposed TypeSize, but having this variable named 'MinSize' is a bit odd when you compare with Zero, because in a sense, the minimum size of <anything> is always zero :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76748/new/

https://reviews.llvm.org/D76748





More information about the llvm-commits mailing list