[PATCH] D76674: [Attributor] Derive better alignment for accessed pointers

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 10:50:32 PDT 2020


lebedev.ri added a comment.

In D76674#1944250 <https://reviews.llvm.org/D76674#1944250>, @uenoku wrote:

> Why can't we use ABI info without known access?
>  I mean, is it possible to use ABI info in initialize?


See my previous comment.
If we decide that pointer has ABI alignment from the get go,
then we will immediately update every underaligned load/store to no longer be underaligned,
which makes no sense. Unless i'm horribly mistaken, just because we said that %z is `i32*` or `i512*`,
it doesn't mean it us UB for it to be aligned to a singled byte (`& 0b1 == 1`),
it is the access to such misaligned pointer that is UB.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76674/new/

https://reviews.llvm.org/D76674





More information about the llvm-commits mailing list