[PATCH] D76848: [CodeGen] Error when writing to reserved registers in inline asm

Victor Campos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 10:18:19 PDT 2020


vhscampos added a comment.

It is diagnosing the same cases as the similar check present in CodeGen/AsmPrinter/AsmPrinterInlineAsm.cpp, lines 549-585. The latter, however, only covers clobber operands, leaving input and output operands unchecked.

I created these diagnostics in SelectionDAGBuilder.cpp, rather than in AsmPrinterInlineAsm.cpp, because, in the latter, it's too late to catch the case where input operands are reserved registers (i.e. inline asm's "local register variables").

It may diagnose more cases than GCC, but that is simply incidental as I just tried to mimick what is done with clobber registers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76848/new/

https://reviews.llvm.org/D76848





More information about the llvm-commits mailing list