[PATCH] D76124: [TTI] Remove getOperationCost

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 09:12:35 PDT 2020


spatel added subscribers: jonpa, uweigand.
spatel added a comment.

In D76124#1943194 <https://reviews.llvm.org/D76124#1943194>, @samparker wrote:

> > Anything we can do to clean up and simplify these classes is welcome, but it probably requires cleaning up the user classes too
>
> @spatel my aim for this patch was to hoist the getOperationCost functionality into its only user 'getUserCost', while also providing the backends a better chance of conveying costs. I know I've got a couple of comments from @lebedev.ri to see to, but do see any fundamental issues with this change?


Nope - looks like a valid confusion reduction step to me. Are we ok with the SystemZ change? cc @uweigand @jonpa


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76124/new/

https://reviews.llvm.org/D76124





More information about the llvm-commits mailing list