[PATCH] D76838: [LV] WIP: Tail-folding counting down loops

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 07:01:03 PDT 2020


samparker added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorizationLegality.cpp:525
 
+  auto IsStepValueMinusOne = [&] () {
+    if (ID.getConstIntStepValue()->isMinusOne())
----------------
why aren't these lambdas just a bools?


================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:1828
 
+  auto IsStepValueMinusOne = [&] () -> bool {
+      return ID.getConstIntStepValue() &&
----------------
same here.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76838/new/

https://reviews.llvm.org/D76838





More information about the llvm-commits mailing list