[PATCH] D76817: `shape` dialect: add some ops

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 26 05:55:40 PDT 2020


jpienaar added inline comments.


================
Comment at: mlir/include/mlir/Dialect/Shape/IR/ShapeOps.td:315
 
+def Shape_DropBackOp : Shape_Op<"drop_back", []> {
+  let summary = "Drops dimensions off the back of a shape.";
----------------
Instead of drop back and take back, how about an op that mirrors concat (well mirrors the binary concat) like split_at which produces two shapes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76817/new/

https://reviews.llvm.org/D76817





More information about the llvm-commits mailing list