[PATCH] D75837: [MLIR] Introduce std.execute_region op

Thu Mar 26 04:50:51 PDT 2020

bondhugula added a comment.

In D75837#1940549 <https://reviews.llvm.org/D75837#1940549>, @rriddle wrote:

> I added some more nits, mostly to keep this consistent with the changes coming in D76743 <https://reviews.llvm.org/D76743>
>
> Also, std.yield seems good.

Should the std.yield terminator be introduced in this patch or another one? It's not a trivial because std.yield's verify should pretty much be doing what the FuncOp's verify does in D71961 <https://reviews.llvm.org/D71961> for imperative ops. Also, the YieldOp name is used by both Loop and Linalg dialect without a namespace qualifier which causes a conflict and requires many updates. I've anyway gone ahead and done those. PTAL.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75837/new/

https://reviews.llvm.org/D75837