[PATCH] D76700: [MLIR] Introduce full/partial tile separation using if/else

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added inline comments.


================
Comment at: mlir/lib/Transforms/Utils/LoopUtils.cpp:2135
+
+  // Add the body of the full tile loop.
+  BlockAndValueMapping operandMap;
----------------
andydavis1 wrote:
> This function is kind of long. Would make sense to break it in two, and start the bottom half here?
Done. I actually moved the first half (along with the 'add the body' part') into its own function - createFullTiles. This was logically one thing. That simplifies the cleanup on error as well and leads to a smaller separateFullTiles. Thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76700/new/

https://reviews.llvm.org/D76700