[PATCH] D76735: [mlir][SPIRV] Update dialect/op documentation to be consistent with the rest of the dialects

River Riddle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 21:39:23 PDT 2020


rriddle added a comment.

In D76735#1942386 <https://reviews.llvm.org/D76735#1942386>, @mravishankar wrote:

> A lot of this is auto-generated using https://github.com/llvm/llvm-project/blob/master/mlir/utils/spirv/gen_spirv_dialect.py . Would be better to update that so that it doesnt get reverted when we use the script to regenerate the .td files.  Let me know if you want one of us to take that up (should be a simple change.


Yes that would be great. Is that going to subsume all of the changes here in the .td files? Note, the .md changes are still necessary regardless.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76735/new/

https://reviews.llvm.org/D76735





More information about the llvm-commits mailing list