[llvm] affed19 - Remove overly verbose debug from GenericDomTreeConstruction

Mehdi Amini via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 18:03:53 PDT 2020


Author: Mehdi Amini
Date: 2020-03-26T01:03:40Z
New Revision: affed19fc38c91b155e5d1fff021a20c910e1b0d

URL: https://github.com/llvm/llvm-project/commit/affed19fc38c91b155e5d1fff021a20c910e1b0d
DIFF: https://github.com/llvm/llvm-project/commit/affed19fc38c91b155e5d1fff021a20c910e1b0d.diff

LOG: Remove overly verbose debug from GenericDomTreeConstruction

This particular debug shows all the time when I'm processing any MLIR
module:

	discovered a new reachable node ^bb0
	discovered a new reachable node ^bb0
	discovered a new reachable node ^bb0
	discovered a new reachable node ^bb0
        ...
        (repeated x1875)

I think that printing all the basic blocks in the function is likely low
value enough that we can get away with removing this.

Differential Revision: https://reviews.llvm.org/D76813

Added: 
    

Modified: 
    llvm/include/llvm/Support/GenericDomTreeConstruction.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/GenericDomTreeConstruction.h b/llvm/include/llvm/Support/GenericDomTreeConstruction.h
index 571550012374..a344f66c548e 100644
--- a/llvm/include/llvm/Support/GenericDomTreeConstruction.h
+++ b/llvm/include/llvm/Support/GenericDomTreeConstruction.h
@@ -599,8 +599,6 @@ struct SemiNCAInfo {
     // Loop over all of the discovered blocks in the function...
     for (size_t i = 1, e = NumToNode.size(); i != e; ++i) {
       NodePtr W = NumToNode[i];
-      LLVM_DEBUG(dbgs() << "\tdiscovered a new reachable node "
-                        << BlockNamePrinter(W) << "\n");
 
       // Don't replace this with 'count', the insertion side effect is important
       if (DT.DomTreeNodes[W]) continue;  // Haven't calculated this node yet?


        


More information about the llvm-commits mailing list