[PATCH] D76784: [WebAssembly] Clear frame base vreg in explicit-locals when stack pointer is dead

Wouter van Oortmerssen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 16:16:57 PDT 2020


aardappel accepted this revision.
aardappel added a comment.
This revision is now accepted and ready to land.

You mean `alloca` as in the C function, not as in the LLVM concept, I guess.

And yes, this is all very brittle code, having to potentially call these functions upon each register change. I wonder if there's a better way, like making the concept of FrameBase be a flag on a register, such that when the register gets deleted it is automatic. But that would probably still require special purpose when renumbered, when lowered to a local, etc etc.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76784/new/

https://reviews.llvm.org/D76784





More information about the llvm-commits mailing list