[PATCH] D76789: [AMDGPU] Preserve original symbol during attribute propagation

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 13:33:03 PDT 2020


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPropagateAttributes.cpp:282
-    F.setVisibility(GlobalValue::DefaultVisibility);
-    F.setLinkage(GlobalValue::InternalLinkage);
   }
----------------
arsenm wrote:
> The linkage wasn't set before for anonymous functions? That should get a test?
It is universally set now on every clone as we do not mess with the original function name anymore.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76789/new/

https://reviews.llvm.org/D76789





More information about the llvm-commits mailing list