[PATCH] D76787: [mlir][Diagnostics] Don't print note source line if it is the same as the previous diagnostic

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 10:50:37 PDT 2020


mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.

We don't have tests for the note emission?



================
Comment at: mlir/include/mlir/IR/Diagnostics.h:551
+  void emitDiagnostic(Location loc, Twine message, DiagnosticSeverity kind,
+                      bool displaySourceLine = true);
 
----------------
Worth documenting it here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76787/new/

https://reviews.llvm.org/D76787





More information about the llvm-commits mailing list