[PATCH] D44543: [AsmPrinter] Emit .weak directive for weak linkage on COFF

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 10:48:04 PDT 2020


mstorsjo added a comment.

Or would it be best to extend the generic MCAsmInfo with another function, and change the existing condition into `(MAI->hasLinkOnceDirective() && (GV->hasComdat() || !MAI->linkOnceDirectiveRequiresComdat()))`? That makes the condition both generic and clearer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D44543/new/

https://reviews.llvm.org/D44543





More information about the llvm-commits mailing list