[PATCH] D76673: [Attributor][FIX] Prevent alignment breakage wrt. must-tail calls

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 08:04:40 PDT 2020


jdoerfert added a subscriber: rnk.
jdoerfert added a comment.

In D76673#1941116 <https://reviews.llvm.org/D76673#1941116>, @uenoku wrote:

> > Good point. It is about:
> >  Attribute::StructRet, Attribute::ByVal, Attribute::InAlloca, Attribute::InReg, Attribute::Returned, Attribute::SwiftSelf, Attribute::SwiftError, Attribute::Alignment
>
> Seems reasonable but I'm not sure why we need to care about `returned`.


It's in the verifier's list that is checked. @rnk can you confirm `returned` needs to be kept in-sync between caller and callee of a must-tail call?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76673/new/

https://reviews.llvm.org/D76673





More information about the llvm-commits mailing list