[PATCH] D72973: using symbol index+symbol name + storage mapping class as label for llvm-objdump -D

[Digger via Phabricator via llvm-commits]

DiggerLin added inline comments.


================
Comment at: llvm/lib/BinaryFormat/XCOFF.cpp:41
   }
+  return "Unknown";
 }
----------------
jhenderson wrote:
> DiggerLin wrote:
> > jhenderson wrote:
> > > Test-case using this? More generally, you should have a test case for all the supported SMC values probably (i.e. showing how they're printed), rather than a subset. You could use a unit test instead of a lit test if it's not possible to hit all cases at this point, or consider a yaml2obj extension.
> > llvm yaml2obj do not support xcoff currently. We can add a test case for this when the llvm yaml2obj support xcoff.
> Are you planning on adding support to yaml2obj any time soon?
> 
> Please add a TODO to this code saying that it needs testing.
I do not think we are planning to  adding XCOFF support to yaml2obj soon.
I added  TODO here. thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D72973/new/

https://reviews.llvm.org/D72973