[PATCH] D76775: [ThinLTO] Don't rely on debug output for thinlto_samplepgo_icp3 test

Alexandre Ganea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 08:04:31 PDT 2020


aganea created this revision.
aganea added reviewers: tejohnson, mehdi_amini.
Herald added subscribers: llvm-commits, dexonsmith, steven_wu, hiraditya, inglorion.
Herald added a project: LLVM.

As suggested here: https://reviews.llvm.org/D18487#1940131 make the test rely on `llvm-dis` instead. Also remove the erroneous `ICALL-PROM` part.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D76775

Files:
  llvm/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll


Index: llvm/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll
===================================================================
--- llvm/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll
+++ llvm/test/Transforms/PGOProfile/thinlto_samplepgo_icp3.ll
@@ -6,9 +6,11 @@
 
 ; Test to make sure importing and dead stripping works in the
 ; case where the target is a local function that also indirectly calls itself.
-; RUN: llvm-lto2 run -thinlto-threads=1 -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l -print-imports 2>&1 | FileCheck %s --check-prefix=IMPORTS
+; RUN: llvm-lto2 run -thinlto-threads=1 -save-temps -o %t3 %t.bc %t2.bc -r %t.bc,fptr,plx -r %t.bc,main,plx -r %t2.bc,_Z6updatei,pl -r %t2.bc,fptr,l
+; RUN: llvm-dis %t3.1.3.import.bc -o - | FileCheck %s --check-prefix=IMPORTS
+
 ; Make sure we import the promted indirectly called target
-; IMPORTS: Import _ZL3foov.llvm.0
+; IMPORTS: void @_ZL3foov.llvm.0()
 
 target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"
@@ -19,7 +21,6 @@
 define i32 @main() local_unnamed_addr #0 !prof !34 {
 entry:
   %0 = load void ()*, void ()** @fptr, align 8
-; ICALL-PROM:   br i1 %{{[0-9]+}}, label %if.true.direct_targ, label %if.false.orig_indirect
   tail call void %0(), !prof !40
   ret i32 0
 }


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D76775.252571.patch
Type: text/x-patch
Size: 1400 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200325/c8224d0f/attachment.bin>


More information about the llvm-commits mailing list