[PATCH] D76739: [llvm-objdump] Replace array_pod_sort with llvm::stable_sort

Dave Bozier via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 25 07:32:16 PDT 2020


davidb added inline comments.


================
Comment at: llvm/tools/llvm-objdump/llvm-objdump.cpp:1205-1207
+  // Create a mapping from virtual address to section. An empty section can
+  // cause more than one section at the same address. Use a stable sort to
+  // stabalize the output.
----------------
thopre wrote:
> Also non allocatable sections have 0 for start address. Dunno if it's worth mentioning.
Might be worth considering this as a future change. I think excluding sections that do not have SHF_ALLOC could cause issues in some cases where one might forget to set the appropriate section flags in assembly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76739/new/

https://reviews.llvm.org/D76739





More information about the llvm-commits mailing list