[PATCH] D75756: [llvm-objdump] Teach `llvm-objdump` dump dynamic symbols.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.

Two minor comments. Otherwise, looks good to me.



================
Comment at: llvm/test/tools/llvm-objdump/unimplemented-features.test:4
+# RUN: llvm-objdump --dynamic-syms %t1.o 2>&1 | \
+# RUN:   FileCheck %s -DFILE=%t1.o --match-full-lines --strict-whitespace
+
----------------
You can get rid of --match-full-lines and --strict-whitespace form here and below. This is only testing a warning, not the output format of an option.


================
Comment at: llvm/test/tools/llvm-objdump/unimplemented-features.test:6
+
+## Test dumping dynamic symbols reports a warning if the operation is unsupported for the file format.
+# RUN: yaml2obj %s --docnum=2 -o %t2.o
----------------
No need to duplicate this comment throughout this test. The one at the top is sufficient (you can get rid of the extra blank lines then too. You can keep the old comments for "Mach-O/COFF object file" if you like, or just name the output files `%t.coff.o`, and `%t.macho.o` to make them self-documenting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75756/new/

https://reviews.llvm.org/D75756