[PATCH] D76673: [Attributor][FIX] Prevent alignment breakage wrt. must-tail calls

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 23:57:34 PDT 2020


lebedev.ri added a comment.

Thanks, this looks about reasonable to me, although i'm not familiar with this code to fully review it.



================
Comment at: llvm/lib/Transforms/IPO/Attributor.cpp:1332
+    // If the associated argument is involved in a must-tail call we give up
+    // because we would need to keep the argument alignments of caller and
+    // callee in-sync. Just does not seem worth the trouble right now.
----------------
We are in `AAReturnedValues`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76673/new/

https://reviews.llvm.org/D76673





More information about the llvm-commits mailing list