[PATCH] D76749: [ASan] Fix issue where system log buffer was not cleared after reporting an issue.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 22:24:43 PDT 2020


vitalybuka added inline comments.


================
Comment at: compiler-rt/lib/asan/asan_report.cpp:58
 
+void ClearErrorMessageBuffer() {
+  BlockingMutexLock l(&error_message_buf_mutex);
----------------
static?
or maybe just avoid a function 


================
Comment at: compiler-rt/lib/asan/asan_report.cpp:167
       internal_memcpy(buffer_copy.data(),
                       error_message_buffer, kErrorMessageBufferSize);
     }
----------------
I guess it should be reset here just after internal_memcpy under the same lock


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76749/new/

https://reviews.llvm.org/D76749





More information about the llvm-commits mailing list