[PATCH] D76752: Move event section before global section

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 21:28:48 PDT 2020


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: llvm/lib/Object/WasmObjectFile.cpp:1654
+         WASM_SEC_ORDER_TARGET_FEATURES}, // WASM_SEC_ORDER_PRODUCERS,
+        {WASM_SEC_ORDER_TARGET_FEATURES}  // WASM_SEC_ORDER_TARGET_FEATURES
 };
----------------
Hmm, clang-format makes this look ugly, and I think I remember you decided not to format this code intentionally before, but having consistent style throughtout wasm code is also better. WDYT? @tlively 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76752/new/

https://reviews.llvm.org/D76752





More information about the llvm-commits mailing list