[PATCH] D76742: [lld] Add basic symbol table output

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 20:15:04 PDT 2020


int3 added inline comments.


================
Comment at: lld/MachO/Writer.cpp:104
   SmallVector<char, 128> contents;
+  raw_svector_ostream os{contents};
 };
----------------
this could be constructed locally in the using method I think


================
Comment at: lld/test/MachO/symtab_basic.s:40
+.text
+.global bar
+.global foo
----------------
maybe put one of these in a different section like `.data`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76742/new/

https://reviews.llvm.org/D76742





More information about the llvm-commits mailing list