[PATCH] D74781: Wasm-ld emits invalid .debug_ranges entries for non-live symbols

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: llvm/test/DebugInfo/WebAssembly/dbg-ranges-nonlive-symbols.test:1
+RUN: rm -rf %t && mkdir -p %t
+RUN: clang -gfull --target=wasm32 -ffunction-sections -fdata-sections -c %S/Inputs/nonlive-symbols1.c -o %t/nonlive-symbols1.o
----------------
I think this needs to be a wasm-ld test doesn't it?

I think it should live in lld/test/wasm.      Also the test inputs should be `.ll` if possible to avoid depending on clang.  Also, the first input can be inline within the test file itself (`dbg-ranges-nonlive-symbols.ll`).

Alternative we could modify an existing test.. wait there is already: `lld/test/wasm/debug-removed-fn.ll`.  Is this change not already covered by that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74781/new/

https://reviews.llvm.org/D74781