[PATCH] D76668: [lld][ELF] Ignore __start/__stop symbols in section groups during GC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 13:28:39 PDT 2020


MaskRay added a comment.

This change changes the rL297049 <https://reviews.llvm.org/rL297049> logic to not apply on sections within a group. My currently feeling is that rL297049 <https://reviews.llvm.org/rL297049> is too conservative. We should check what will break if we drop rL297049 <https://reviews.llvm.org/rL297049>, and only special case sections which absolutely need such retaining behavior.

See D76410 <https://reviews.llvm.org/D76410> for the most recent discussion on `__start_$sectionname`/`__stop_$sectionname` symbols.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76668/new/

https://reviews.llvm.org/D76668





More information about the llvm-commits mailing list