[PATCH] D76715: [mlir] Clarify constraint on derived attribute

Jacques Pienaar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 13:28:34 PDT 2020


jpienaar added inline comments.


================
Comment at: mlir/docs/OpDefinitions.md:183
 
+   All derived attributes should be materializable as an Attribute. That is,
+   even though they are not materialized, it should be possible to store as
----------------
rriddle wrote:
> Why is this indented?
It is a second paragraph under the numbered list item.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76715/new/

https://reviews.llvm.org/D76715





More information about the llvm-commits mailing list