[PATCH] D76721: Clarify use of llvm_unreachable in the coding standard

Aaron Ballman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 13:28:34 PDT 2020


aaron.ballman marked 2 inline comments as done.
aaron.ballman added inline comments.


================
Comment at: llvm/docs/CodingStandards.rst:1160
+unconditionally a bug of some kind. Use of ``assert`` should always include a
+testable predicate (as opposed to ``assert(false)``).
+
----------------
hubert.reinterpretcast wrote:
> Suggestion:
> [ ... ] bug<ins> (not originating from user input; see below)</ins> of some kind. [ ... ]
> 
> Also, it would help for the patch to include more context.
Done, and thank you for the reminder about diff context.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76721/new/

https://reviews.llvm.org/D76721





More information about the llvm-commits mailing list