[PATCH] D76640: [GlobalISel] Combine (x op 0) -> x for operations with a right identity of 0

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 24 12:21:24 PDT 2020


arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:222
+  /// \p C.
+  bool matchConstantOp(const MachineOperand &MOP, int64_t C);
+
----------------
paquette wrote:
> aemerson wrote:
> > arsenm wrote:
> > > The people on your twitter poll are insane and MO is the clearly dominant abbreviation
> > Yes, this is terrible. And for that reason, I'm out.
> 58.93 twitter users agree that MOP is the morally superior abbreviation
There's no word beginning with P here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76640/new/

https://reviews.llvm.org/D76640





More information about the llvm-commits mailing list